Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P2PS] / Ameerul / P2PS-2084 Improvise Deriv P2P Available Balance Information #12924

Merged
merged 2 commits into from
Jan 19, 2024
Merged

[P2PS] / Ameerul / P2PS-2084 Improvise Deriv P2P Available Balance Information #12924

merged 2 commits into from
Jan 19, 2024

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • updated the my-profile-balance-modal with the new description

Screenshots:

Please provide some screenshots of the change.
Screenshot 2024-01-12 at 12 21 00 PM
Screenshot 2024-01-12 at 12 21 07 PM

@boring-cyborg boring-cyborg bot added the P2P label Jan 12, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 15, 2024 1:52am

@ameerul-deriv ameerul-deriv marked this pull request as ready for review January 12, 2024 04:21
@coveralls
Copy link

coveralls commented Jan 12, 2024 •
edited
Loading

Coverage Status

coverage: 34.656% (+0.01%) from 34.646%
when pulling b0600e5 on ameerul-deriv:P2PS-2084-improvise-deriv-p2p-available-balance-information
into f158f94 on binary-com:master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12924](https://github.com/binary-com/deriv-app/pull/12924)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2084-improvise-der-824930.binary.sx?qa_server=red.derivws.com&app_id=32920
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2084-improvise-der-824930.binary.sx
- **App ID**: `32920`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-2084-improvise-der-824930.binary.sx/

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
6.6% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@farrah-deriv farrah-deriv merged commit ce1dadc into binary-com:master Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farrah-deriv farrah-deriv farrah-deriv approved these changes

@nada-deriv nada-deriv nada-deriv approved these changes

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

Assignees
No one assigned
Labels
P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameerul-deriv @coveralls @farrah-deriv @nada-deriv